Enforce minimum gameplay sample volume of 5% #25185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
added a commit
to bdach/osu
that referenced
this pull request
Oct 23, 2023
Noticed this during work on ppy#25185. In some circumstances, it seemed that spinner bonus ticks (and mostly them specifically) would not always play with the correct volume. Hours of debugging later pointed at a trace at `DrawableAudioWrapper.refreshLayoutFromParent()` not firing sometimes. Initially I thought it to be some sort of framework bug, but after preparing a diff and running final checks, I noticed that sometimes the sample was being played *by a `PoolableSkinnableSample` that wasn't loaded*. And determining why *that* is the case turned out with this diff. As it happens, spinner ticks get assigned a start time proportionally, i.e. the 1st of 10 ticks is placed at 10% of the duration, the 2nd at 20%, and so on. The start time generally shouldn't matter, because the spinner is manually judging the ticks. *However*, the ticks *still* receive a lifetime start / end in the same way normal objects do, which means that in some cases they can *not be alive* when they're hit, which means that the `DrawableAudioWrapper` flow *hasn't had a chance to run*, and rightly so. To fix, ensure that all spinner ticks are alive throughout the entirety of the spinner's duration.
peppy
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Addresses #25165 (comment)
As per my comment there, stable's sample volume floor is actually 8%, but it is enforced in what seem to be completely stupid ways (in the UI it's 5%, but actual playback takes place at minimum 8%). Since that seems weird and bad, and basically nobody seems to know about it (source: a brief discussion I had with the NAT today), and it seems there should be no harm in actually having the cap be 5% without weird gymnastics or lying to the users, that's what I ended up doing.
Testing resources
VolumeTesting.zip contains 3 beatmaps:
HitCircleVolumecontains 25 hitcircles with 1 sec spacing, with volume ranging from 0 to 24HitCircleSlidercontains 15 sliders with 3 sec spacing, with volume ranging from 0 to 14HitCircleSpinnercontains 15 spinners with 3 sec spacing, with volume ranging from 0 to 14taiko was also tested on
HitCircleVolumeto cover theGameplaySampleTriggerSourcepart of this diff.Test results
Recordings obtained from playing back the beatmaps as WAV files are available here:
Recordings were captured via 'stereo mix' input on my windows box. Visual waveform comparison, for convenience:
Please disregard the weird tick spam on the
spinnerscase. I'm not sure where that's coming from but it's pretty clearly not broken by this PR.I'll investigate the cause of this in more detail later.This is fixed by #25216.