No hitsound when hit objects' volume is on 5% on lazer

[SedjamTan]

Type

Game behaviour

Bug description

I noticed while playing this map that certain hit objects don't have a hitsound on lazer compared to stable. Upon checking the beatmap in the editor, those hitobjects have a volume of 5%.

Some of the hit objects with volume of 5%:
0:39:260
0:39:450
0:49:969
0:44:007
0:46:476

Screenshots or videos

Stable

osu-stable-skin.mp4

Lazer

osu-lazer-skin.mp4

Version

2023.1008.1

Logs

performance.log
runtime.log
updater.log
database.log
network.log

[peppy]

Stable enforces a 5% minimum. It's probably not yet implemented.

[bdach]

Stable enforces a 5% minimum. It's probably not yet implemented.

Are you referring to this thing?

https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/Audio/AudioEngine.cs#L1070
https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/Audio/AudioEngine.cs#L1404-L1405

If yes, then that's 8%, but that still doesn't explain the massive volume difference. Whatever this thing is probably would though.

We already apply leniency here:

osu/osu.Game/Beatmaps/Formats/LegacyBeatmapDecoder.cs

Line 115 in f36a671

SampleControlPoint sampleControlPoint = (beatmap.ControlPointInfo as LegacyControlPointInfo)?.SamplePointAt(hitObject.GetEndTime() + control_point_leniency) ?? SampleControlPoint.DEFAULT;

Not yet sure why it isn't enough in this case.