Fix wrong range constrained bindable value transferal in CopyTo()
#5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regressed in 9faae09. When copying over values of a range-constrained bindable, the range bounds need to be transferred first, because assignment to `.Value` of a range-constrained bindable will automatically clamp the value to [`MinValue`, `MaxValue`], leading to a scenario where a new value being transferred across would get clamped to stale bounds. This affected both `.CopyTo()` and `.BindTo()`, as the latter calls the former.
peppy
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in 9faae09.
When copying over values of a range-constrained bindable, the range bounds need to be transferred first, because otherwise assignment to
.Valueof a range-constrained bindable will automatically clamp the value to [MinValue,MaxValue], leading to a scenario where a new value being transferred across would get clamped to stale bounds.This affected both
.CopyTo()and.BindTo(), as the latter calls the former.