Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update framework #21298

Merged
merged 17 commits into from
Nov 26, 2022
Merged

Update framework #21298

merged 17 commits into from
Nov 26, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Nov 18, 2022 •
edited
Loading

@ppy ppy deleted a comment from amyulating Nov 18, 2022
@bdach
Copy link
Collaborator

bdach commented Nov 18, 2022

I assume this is blocked on another framework release with ppy/osu-framework#5527 included, right? (see code quality inspections)

@peppy
Copy link
Member Author

peppy commented Nov 19, 2022

Yep, probably best we wait for that.

@bdach bdach added the blocked Don't merge this. label Nov 19, 2022
@peppy peppy removed the blocked Don't merge this. label Nov 23, 2022
bdach
bdach previously approved these changes Nov 26, 2022
View reviewed changes
@bdach bdach dismissed their stale review November 26, 2022 16:14

nope, mobile

@bdach bdach mentioned this pull request Nov 26, 2022
Merged
2 tasks
@bdach bdach merged commit b35e796 into ppy:master Nov 26, 2022
@peppy peppy deleted the update-framework branch November 27, 2022 05:56
@bdach bdach mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peppy @bdach @smoogipoo