Merge flibitijibibo master #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So no kludging with an array interop.
This function should return an SDL_bool, not void per SDL wiki https://wiki.libsdl.org/SDL_HasARMSIMD. This will possibly have an effect on armv7 and early armv8 platforms so it's important it gets fixed.
The previous signature was different from the one actually implemented in SDL / the one in the documentation. This fixes it and makes it on par with the implementation and the documentation
* Use generic versions of Marshal.PtrToStructure and Marshal.SizeOf * Use generic version of Marshal.GetDelegateForFunctionPointer * Update target frameworks * Mark assembly as trimmable and enable AOT analyzer
5 tasks
peppy
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL_GetTouchNameflibitijibibo/SDL2-CS#234which is needed for Fix Windows Ink events being handled as touch events osu-framework#5309
Of the other changes, only really 408bf22 is interesting to us because of trimming/NativeAOT for iOS.