Support trimming and AOT #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly 4.0 will be a hard requirement pretty much forever (FNA requirement), but we already have a NETSTANDARD define so let's reuse that, since this is likely going to be mainly for NativeAOT anyway. |
… supported frameworks
|
Alright, I've readded 4.0 support using defines. |
flibitijibibo
approved these changes
Nov 25, 2022
|
Quick note for this one: Turns out Would be nice to remove the redundant cast, but this is still better than nothing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the trimming and AOT analyzers, and fixes all of the corresponding warnings. There were only a few to fix, and they were all fixed by using the generic versions of some marshalling functions.
Unfortunately, those functions were introduced in .NET 4.5.1, so I had to bump the minimum framework to that. Hopefully this shouldn't cause too much of a problem, since .NET 4.0 is already long out of support.
I also added .NET 7.0 as a target framework so that AOT warnings are displayed during compilation (but that can be removed if wanted).