Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak README #154

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Tweak README #154

merged 3 commits into from
Jul 11, 2023

Conversation

ml-evs
Copy link
Collaborator

@ml-evs ml-evs commented Jun 17, 2023

I think this looks marginally cleaner

Copy link
Owner

@ppdebreuck ppdebreuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@ppdebreuck ppdebreuck self-assigned this Jun 18, 2023
@ml-evs
Copy link
Collaborator Author

ml-evs commented Jun 24, 2023

Here's the root cause of the test failures, have asked for it to be fixed upstream: materialsproject/api#819

@ppdebreuck
Copy link
Owner

emmet-core pinning seems not to help ? Any idea ?

@ml-evs
Copy link
Collaborator Author

ml-evs commented Jul 11, 2023

Indeed, now things are broken because pydantic 2.0 has been released and no-one was pinning to v1...

@ppdebreuck ppdebreuck merged commit 75f4712 into master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants