Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken circular dependency versions #819

Closed
ml-evs opened this issue Jun 22, 2023 · 4 comments
Closed

Broken circular dependency versions #819

ml-evs opened this issue Jun 22, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ml-evs
Copy link
Contributor

ml-evs commented Jun 22, 2023

Just running into an issue with MP-API very indirectly via matminer, regardingly the migration of graph hashing code from emmet to pymatgen:

/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/emmet/core/utils.py:22: in <module>
    from pymatgen.util.graph_hashing import weisfeiler_lehman_graph_hash
E   ModuleNotFoundError: No module named 'pymatgen.util.graph_hashing'

matminer depends on mp_api indirectly via pymatgen, and mp_api depends on emmet and pymatgen itself.

A recent migration of code from emmet to pymatgen means that they can only be used together with versions pymtagen>=2023.5.8 and emmet>=0.57, but this package only pins emmet>=0.57. Could you please consider pinning pymatgen>=2023.5.8 explicitly too?

@ml-evs
Copy link
Contributor Author

ml-evs commented Jun 22, 2023

@munrojm
Copy link
Member

munrojm commented Jun 23, 2023

Yup, happy to change this. Thanks for the heads up.

@munrojm munrojm self-assigned this Jun 23, 2023
@munrojm munrojm added the bug Something isn't working label Jun 23, 2023
@ml-evs
Copy link
Contributor Author

ml-evs commented Jun 23, 2023

Thanks @munrojm, hope my explanation was clear enough 😅

@tschaume
Copy link
Member

See #825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants