Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor resource spp placement group and documentation #88

Closed
wants to merge 1 commit into from
Closed

Refactor resource spp placement group and documentation #88

wants to merge 1 commit into from

Conversation

Diptipowervs
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

michaelkad
michaelkad approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelkad michaelkad self-requested a review May 31, 2024 17:50
@michaelkad
Copy link
Collaborator

michaelkad commented Sep 23, 2024 •
edited
Loading

@Alexander-Kita Could you re-open this PR under a different branch?

@michaelkad michaelkad closed this Sep 23, 2024
@Alexander-Kita
Copy link
Collaborator

Alexander-Kita commented Sep 23, 2024 •
edited
Loading

#169 @michaelkad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia Awaiting requested review from ismirlia

@michaelkad michaelkad Awaiting requested review from michaelkad

Assignees
No one assigned
Labels
Refactor Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Diptipowervs @michaelkad @Alexander-Kita