Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix vm shutdown name change, fix VOD bug #188

Closed
wants to merge 1 commit into from

Conversation

Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Dec 13, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Description:

  • Fixes bug where pi_instance hangs when name is updated while instance is shutdown
  • Fixes null pointer exception when updating virtual optic device
  • Adds new wait for update function, waits for both shutdown and active status, used when name/VOD is updated and when memory/cores are updated.

Output from acceptance testing:

pi_instance (r)

=== RUN   TestAccIBMPIInstanceBasic
--- PASS: TestAccIBMPIInstanceBasic (593.46s)
PASS

=== RUN   TestAccIBMPIInstanceUpdateActiveState
--- PASS: TestAccIBMPIInstanceUpdateActiveState (1498.25s)
PASS

=== RUN   TestAccIBMPIInstanceUpdateStoppedState
--- PASS: TestAccIBMPIInstanceUpdateStoppedState (2648.59s)
PASS

@Alexander-Kita Alexander-Kita changed the title Fix vm shutdown name change, fix VOD bug [Bug Fix] Fix vm shutdown name change, fix VOD bug Dec 13, 2024
ismirlia
ismirlia previously approved these changes Dec 16, 2024
@Alexander-Kita Alexander-Kita force-pushed the pi-instance-shutdown-name-change-bug branch from dd162ba to 901bf06 Compare December 17, 2024 17:58
@Alexander-Kita
Copy link
Collaborator Author

Opened IBM-Cloud#5881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants