[Bug Fix] Fix hanging after name update when vm shutdown, fix null po… #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Kita
requested review from
yussufsh,
hkantare,
michaelkad and
ismirlia
ismirlia
previously approved these changes
Dec 17, 2024
Alexander-Kita
commented
Dec 17, 2024
Comment on lines
+681
to
+685
| if d.HasChange(Arg_InstanceName) && d.HasChange(Arg_VirtualOpticalDevice) { | ||
| oldVOD, _ := d.GetChange(Arg_VirtualOpticalDevice) | ||
| d.Set(Arg_VirtualOpticalDevice, oldVOD) | ||
| return diag.Errorf("updates to %s and %s are mutually exclusive", Arg_InstanceName, Arg_VirtualOpticalDevice) | ||
| } |
There was a problem hiding this comment.
Updates are mutually exclusive for name/active vm resources and cloud initialization, so an error is thrown here (clarification comment).
yussufsh
reviewed
Dec 18, 2024
| if err != nil { | ||
| return nil, "", err | ||
| } | ||
| if strings.ToLower(*pvm.Status) == State_Active && pvm.Health.Status == OK { |
There was a problem hiding this comment.
You would also need to check the Arg_HealthStatus
There was a problem hiding this comment.
Added only to active block. Kept shutoff the same since the other update function also only checks for "OK" health status when checking for shutdown (keeps behavior the same).
Alexander-Kita
force-pushed
the
pi-instance-shutdown-name-change-bug
branch
from
901bf06 to
f9ff13c
Compare
…inter error when updating VOD
Alexander-Kita
force-pushed
the
pi-instance-shutdown-name-change-bug
branch
from
f9ff13c to
4bb2d85
Compare
yussufsh
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description:
Output from acceptance testing:
pi_instance (r)