New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resource] Network Security Group Rule #159

Closed

ismirlia wants to merge 26 commits into master from nsg-member

Collaborator

ismirlia commented Aug 16, 2024

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

ismirlia added 3 commits

August 19, 2024 13:39


          Update dependencies

c7c3d8d


          Connect new resource and tests

ddedb39


          Add network security group rule resource

e8e487b

ismirlia force-pushed the nsg-member branch from 947f432 to 0ca2803 Compare

August 19, 2024 19:38

michaelkad reviewed

View reviewed changes

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

michaelkad reviewed

View reviewed changes

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved


          Add network security group rule markdown

f496990

ismirlia force-pushed the nsg-member branch from 0ca2803 to f496990 Compare

August 19, 2024 21:01

michaelkad reviewed

View reviewed changes

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

michaelkad reviewed

View reviewed changes

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

michaelkad reviewed

View reviewed changes

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

michaelkad reviewed

View reviewed changes

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Show resolved Hide resolved

michaelkad reviewed

View reviewed changes

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

michaelkad reviewed

View reviewed changes

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

michaelkad reviewed

View reviewed changes

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

michaelkad requested changes

View reviewed changes

Collaborator

michaelkad left a comment

The title is correct, should be Rule instead of Member.

ismirlia changed the title ~~[Resource] Network Security Group Member~~ [Resource] Network Security Group Rule

ismirlia and others added 6 commits

August 20, 2024 15:36


          Add constants and fix member/rule mixup

02ee544


          Fix network security group rule delete

d7a8976


          Beta 10 fixes

ce1028c


          Remove commented out code

d5a3fdc


          Merge branch 'master' into nsg-member

6ea40e5


          Beta 11 fixes

b10d13e

ismirlia requested a review from michaelkad

August 27, 2024 19:15

ismirlia added 5 commits

September 5, 2024 14:35


          Merge branch 'master' of github.com:powervs-ibm/terraform-provider-ib…

5f0f3f9

…m into nsg-member


          Fix nsg rule schema

4bd772c


          Add nsg rule test

4eab5f0


          Update to beta13

e777c9f


          Update icmp_types

b23bf29

ismirlia marked this pull request as ready for review

September 6, 2024 16:41

ismirlia requested a review from Alexander-Kita

September 6, 2024 16:41

Alexander-Kita reviewed

View reviewed changes

website/docs/r/pi_network_security_group_rule.html.markdown Outdated Show resolved Hide resolved

Alexander-Kita reviewed

View reviewed changes

website/docs/r/pi_network_security_group_rule.html.markdown Outdated Show resolved Hide resolved

Alexander-Kita reviewed

View reviewed changes

website/docs/r/pi_network_security_group_rule.html.markdown Outdated Show resolved Hide resolved

Alexander-Kita reviewed

View reviewed changes

website/docs/r/pi_network_security_group_rule.html.markdown Outdated Show resolved Hide resolved


          Fix tcp flag case

e162e8d

Alexander-Kita reviewed

View reviewed changes

ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved

ismirlia added 2 commits

September 9, 2024 10:07


          Update tcg flag schema


          Update nsg rule integration tests

76bd323

Collaborator Author

ismirlia commented Sep 9, 2024

Unit test results:

--- PASS: TestAccIBMPINetworkSecurityGroupRuleBasic (31.59s)
PASS

--- PASS: TestAccIBMPINetworkSecurityGroupRuleTCP (34.92s)
PASS

--- PASS: TestAccIBMPINetworkSecurityGroupRuleRemove (22.49s)
PASS

ismirlia requested a review from Alexander-Kita

September 9, 2024 15:11

Alexander-Kita reviewed

View reviewed changes

website/docs/r/pi_network_security_group_rule.html.markdown Outdated Show resolved Hide resolved


          Update markdown

4c0f269

michaelkad requested changes

View reviewed changes

Collaborator

michaelkad left a comment

Few changes

ibm/flex/structures.go Outdated Show resolved Hide resolved

ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved

ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved

ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved

ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

ibm/service/power/resource_ibm_pi_network_security_group_rule.go Outdated Show resolved Hide resolved

ismirlia added 4 commits

September 9, 2024 14:28


          Fix member set

90e1c9f


          Remove unused code

f12d668


          Merge branch 'master' of github.com:powervs-ibm/terraform-provider-ib…

4d37ade

…m into nsg-member


          Update to beta15

966e7aa

ismirlia requested review from Alexander-Kita and michaelkad

September 9, 2024 19:45


          Remove duplicate constants

ae4f8cb

Alexander-Kita approved these changes

View reviewed changes

michaelkad approved these changes

View reviewed changes


          Update nsg with beta 17 changes

c080474

Alexander-Kita reviewed

View reviewed changes

website/docs/r/pi_network_security_group_rule.html.markdown Outdated

+                      maximum = 19500
+                    }
+                    pi_protocol {
+                      icmp_types = []

Collaborator

Alexander-Kita Sep 16, 2024

This argument needs to be updated everywhere it is present in the documentation, including no longer having to provide an empty array.

Collaborator Author

ismirlia Sep 18, 2024

Updated


          Fix nsg markdown

d0a153b

Collaborator Author

ismirlia commented Sep 19, 2024

Closing as #157 has incorporated my changes.

ismirlia closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet