Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D,R] Network Security Group, Member, Action #157

Closed
wants to merge 1 commit into from
Closed

[D,R] Network Security Group, Member, Action #157

wants to merge 1 commit into from

Conversation

michaelkad
Copy link
Collaborator

@michaelkad michaelkad commented Aug 14, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPINetworkSecurityGroupDataSourceBasic
--- PASS: TestAccIBMPINetworkSecurityGroupDataSourceBasic (17.98s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupsDataSourceBasic
--- PASS: TestAccIBMPINetworkSecurityGroupDataSourceBasic (16.73s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupMemberBasic
--- PASS: TestAccIBMPINetworkSecurityGroupMemberBasic (27.56s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupBasic
--- PASS: TestAccIBMPINetworkSecurityGroupBasic (88.94s)
PASS

@michaelkad michaelkad force-pushed the network-security-group branch 6 times, most recently from 7ec8379 to 26e064a Compare August 16, 2024 19:04
@michaelkad michaelkad changed the title [D] Network Security Group [D,R] Network Security Group, Member, Action Aug 16, 2024
@michaelkad michaelkad force-pushed the network-security-group branch 2 times, most recently from e2484aa to 07481e8 Compare August 26, 2024 17:05
@michaelkad michaelkad force-pushed the network-security-group branch 2 times, most recently from 85a94b1 to 427e0d8 Compare September 5, 2024 19:48
@michaelkad michaelkad force-pushed the network-security-group branch 3 times, most recently from d81b277 to 0941a74 Compare September 7, 2024 17:06
@michaelkad
Copy link
Collaborator Author 

=== RUN   TestAccIBMPINetworkSecurityGroupBasic
--- PASS: TestAccIBMPINetworkSecurityGroupBasic (33.51s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupMemberBasic
--- PASS: TestAccIBMPINetworkSecurityGroupMemberBasic (90.58s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupsDataSourceBasic
--- PASS: TestAccIBMPINetworkSecurityGroupsDataSourceBasic (14.83s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupDataSourceBasic
--- PASS: TestAccIBMPINetworkSecurityGroupDataSourceBasic (15.99s)
PASS

 === RUN   TestAccIBMPINetworkSecurityGroupRuleBasic
--- PASS: TestAccIBMPINetworkSecurityGroupRuleBasic (36.51s)
PASS

=== RUN   TestAccIBMPINetworkSecurityGroupRuleTCP
--- PASS: TestAccIBMPINetworkSecurityGroupRuleTCP (36.00s)
PASS

@michaelkad michaelkad closed this Oct 14, 2024
@michaelkad michaelkad reopened this Oct 14, 2024
@michaelkad michaelkad force-pushed the network-security-group branch 2 times, most recently from 3e9329b to 69b0e0b Compare October 14, 2024 21:26
ismirlia
ismirlia reviewed Oct 14, 2024
View reviewed changes
ibm/acctest/acctest.go Outdated Show resolved Hide resolved
ismirlia
ismirlia reviewed Oct 14, 2024
View reviewed changes
ibm/service/power/data_source_ibm_pi_network_security_groups.go
"github.com/hashicorp/go-uuid"
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably merge imports here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by merging imports?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just squashing them together, but it's not really important

@michaelkad
[D] Network Security Group
edd12d3 
[R] Add NSG
[R] Add NSG Action
[R] Add NSG Member
[R] Add NSG Member test
[R] Add NSG Rule

Sync go.mod with master

Update to 1.8.3
@michaelkad
Copy link
Collaborator Author

Opened in main repo.

@michaelkad michaelkad closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia ismirlia approved these changes

@Alexander-Kita Alexander-Kita Alexander-Kita approved these changes

Assignees
No one assigned
Labels
Datasource Q4 Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelkad @ismirlia @Alexander-Kita