Add new R extension quickpick to select an interpreter #6213
+130
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a31d94.
Signed-off-by: Julia Silge <julia.silge@gmail.com>
|
E2E Tests 🚀 |
juliasilge
commented
Feb 1, 2025
Comment on lines
+36
to
+39
| export enum RRuntimeSource { | ||
| system = 'System', | ||
| user = 'User', | ||
| homebrew = 'Homebrew', |
There was a problem hiding this comment.
I added this enum to use here and also in the quickpick, for display purposes.
|
|
||
| // R discovery is fast so we just do it before rendering the quick pick | ||
| const runtimePicks: RuntimeQuickPickItem[] = []; | ||
| const discoverer = rRuntimeDiscoverer(); |
There was a problem hiding this comment.
Setting up the quickpick triggers discovery again. Since this is so fast for R, I think this will be more aligned with folks' expectations than a not-entirely-prominent refresh button.
|
|
||
| // If we did in fact get a runtime from the user, select and start it | ||
| if (runtime) { | ||
| const registeredRuntimes = await positron.runtime.getRegisteredRuntimes(); |
There was a problem hiding this comment.
Instead of getting all the registered runtimes and checking whether ours is in it, we could just always re-register the selected one? I don't think it generates errors to register a runtime again.
|
Let's run the console tests since this command is used here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5223
We do have a language agnostic way to generate this kind of feature, as implemented in #3213, but our experience with the "Python: Select Interpreter" command highlights that making these language specific is pretty helpful.
What this PR gets us for R (beyond the existing functionality) now is:
What we could add in the future includes:
Related to the upcoming multiple sessions work and changes to the interpreter dropdown, we'll need to add to the Positron API for extensions so that extensions can say, "Here is my command to select an interpreter", and we can use
r.selectInterpretertogether withpython.setInterpreter. cc @dhruvisompuraLet's run the @:console tests.
Release Notes
New Features
Bug Fixes
QA Notes
brew install r.When you are done, do
brew uninstall rbecause you certainly do not want that R brew installation hanging around. 😆