Select interpreter command #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Smoke test is failing on CI: https://github.com/posit-dev/positron/actions/runs/9176612586/job/25232287089... Need to look into it. |
Base automatically changed from
fix-python-select-interpreter-already-selected
to
main
May 21, 2024 18:10
seeM
force-pushed
the
select-interpreter-command
branch
from
abc169f to
958b679
Compare
jmcphers
approved these changes
May 22, 2024
|
|
||
| input.canSelectMany = false; | ||
| const languageName = languageService.getLanguageName(languageId); | ||
| input.title = `Select ${languageName} Interpreter`; |
There was a problem hiding this comment.
This (and several other strings in this file) needs to be localized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Address #3118.
Approach
Added the
workbench.action.languageRuntime.selectcommand withf1: false. Language packs can implement their own commands in the command palette that call down to this, with alanguageId.I replaced the
workbench.action.languageRuntime.startcommand since this feels like it handles all of the same usecases but with a nicer UX. Happy to revert if I missed something.I also updated smoke tests to use this.
QA Notes
Smoke tests should pass in CI and locally. Try out the R select interpreter command too.