Variable Pane doesn't know how to format formulas #4119
Assignees
Labels
area: variables
Issues related to Variables category.
enhancement
New feature or request
lang: r
support
Milestone
Comments
juliasilge
changed the title
juliasilge
added
enhancement
This was referenced Aug 20, 2024
Notes for when we look at this:From my perspective the main problem is that formulas and other objects like quosures have length > 1 but x <- formula(y ~ a + b + c)
length(x)
#> [1] 3
length(base::format(x))
#> [1] 1Created on 2024-08-23 with reprex v2.1.1 |
lionel-
added a commit
that referenced
this issue
Nov 27, 2024
## Positron Notes
### Release Notes
#### New Features
- The variable pane now supports labels from the {haven} package
(#5327.
- The variable pane has improved support for formulas
(#4119).
#### Bug Fixes
- Assignments in function calls (e.g. `list(x <- 1)`) are now detected
by the missing symbol linter to avoid annoying false positive
diagnostics (#3048). The downside is that this causes
false negatives when the assignment happens in a call with local scope,
e.g. in `local()` or `test_that()`. In these cases the nested
assignments will incorrectly overlast the end of the call. We prefer to
be overly permissive than overly cautious in these matters.
- The following environment variables are now set in the same way that R
does:
- `R_SHARE_DIR`
- `R_INCLUDE_DIR`
- `R_DOC_DIR`
This solves a number of problems in situations that depend on these
variables being defined
(#3637).
Merged
lionel-
added a commit
that referenced
this issue
Nov 27, 2024
### Release Notes
#### New Features
- The variable pane now supports labels from the {haven} package
(#5327.
- The variable pane has improved support for formulas
(#4119).
#### Bug Fixes
- Assignments in function calls (e.g. `list(x <- 1)`) are now detected
by the missing symbol linter to avoid annoying false positive
diagnostics (#3048). The downside is that this causes
false negatives when the assignment happens in a call with local scope,
e.g. in `local()` or `test_that()`. In these cases the nested
assignments will incorrectly overlast the end of the call. We prefer to
be overly permissive than overly cautious in these matters.
- The following environment variables are now set in the same way that R
does:
- `R_SHARE_DIR`
- `R_INCLUDE_DIR`
- `R_DOC_DIR`
This solves a number of problems in situations that depend on these
variables being defined
(#3637).
<!-- Thank you for submitting a pull request.
If this is your first pull request you can find information about
contributing here:
* https://github.com/posit-dev/positron/blob/main/CONTRIBUTING.md
We recommend synchronizing your branch with the latest changes in the
main branch by either pulling or rebasing.
-->
<!--
Describe briefly what problem this pull request resolves, or what
new feature it introduces. Include screenshots of any new or altered
UI. Link to any GitHub issues but avoid "magic" keywords that will
automatically close the issue. If there are any details about your
approach that are unintuitive or you want to draw attention to, please
describe them here.
-->
Verified FixedTest scenario(s)Validated with filing instructions Link(s) to TestRail test cases run or created: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Positron Version:
Positron Version: 2024.07.0 (system setup) build 2024.07.0-85
Code - OSS Version: 1.91.0
Commit: 9dfa34e
Date: 2024-07-22T03:21:08.974Z
Electron: 29.4.0
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.22631
Steps to reproduce the issue:
Run following code, step-by-step:
First, the value of
ffappears in the Variables view. After converting to formula, the value changes to??.variableview.mp4
What did you expect to happen?
The value of
ffchanges to~mo(gear).Were there any error messages in the Output panel or Developer Tools console?
No.
The text was updated successfully, but these errors were encountered: