Downgrade problems in harp_format() to trace
#483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #479
Addresses posit-dev/positron#3115
Today we are again seeing examples of these errors/warnings showing up in logs as red herrings: posit-dev/positron#4437 (comment) so I do think we at least want to fix up the logs.
This does not actually fix how we are displaying formulas and other objects like quosures which have length > 1 but
base::format()results of length 1, i.e. does not address posit-dev/positron#4119.I also changed the name of the functions to more clearly specify they are about vectors.