Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable trial_bp to alleviate error during user creation #322

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

illusional
Copy link

@illusional illusional commented Nov 15, 2023

Currently there's an error when creating a user due to an auth problem when creating the trial billing project - we don't usually use these (it could be created manually anyway), so let's disable it for now.

Revert when this is resolved

More context:
https://hail.zulipchat.com/#narrow/stream/300487-Hail-Batch-Dev/topic/Issue.20creating.20users/near/401890787

Copy link

@jmarshall jmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but please add a comment saying we've temporarily(?) patched this to work around an operational problem.

(I see this is our first patch to this source file.)

@illusional
Copy link
Author

Haha a very reasonable request, thanks @jmarshall!

@jmarshall
Copy link

👍 Excellent comment level of detail

@illusional illusional merged commit 5c73038 into main Nov 15, 2023
4 checks passed
@illusional illusional deleted the temp-disable-creating-trial-bps branch November 15, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants