Sept 23 upstream 4 (dc1f086)

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -1,5 +1,6 @@
 name: Bug Report
 description: Report a bug
+labels: needs-triage
 body:
   - type: textarea
     id: what-happened
@@ -19,5 +20,5 @@ body:
     id: log
     attributes:
       label: Relevant log output
-      description: Please copy and paste any relevant log output.
+      description: Please copy and paste any relevant log output. If too large, please put in https://gist.github.com and provide the link.
       render: shell

.pre-commit-config.yaml

@@ -1,5 +1,22 @@
 ---
+default_install_hook_types: [pre-commit, pre-push]
 repos:
+  - repo: local
+    hooks:
+      - id: ruff
+        name: ruff
+        entry: ruff --fix --show-fixes
+        language: system
+        types: [python]
+        require_serial: true
+      - id: pyright
+        name: pyright
+        entry: pyright
+        language: system
+        types: [python]
+        require_serial: true
+        stages:
+          - pre-push
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v2.3.0
     hooks:

Makefile

@@ -2,7 +2,7 @@
 
 include config.mk
 
-SERVICES := auth batch ci memory notebook monitoring website
+SERVICES := auth batch ci notebook monitoring website
 SERVICES_PLUS_ADMIN_POD := $(SERVICES) admin-pod
 SERVICES_IMAGES := $(patsubst %, %-image, $(SERVICES_PLUS_ADMIN_POD))
 SERVICES_MODULES := $(SERVICES) gear web_common
@@ -35,7 +35,7 @@ check-all: check-hail check-services
 check-hail-fast:
 	ruff check hail/python/hail
 	ruff check hail/python/hailtop
-	$(PYTHON) -m mypy --config-file setup.cfg hail/python/hailtop
+	$(PYTHON) -m pyright hail/python/hailtop
 
 .PHONY: pylint-hailtop
 pylint-hailtop:
@@ -55,7 +55,7 @@ pylint-%:
 .PHONY: check-%-fast
 check-%-fast:
 	ruff check $*
-	$(PYTHON) -m mypy --config-file setup.cfg $*
+	$(PYTHON) -m pyright $*
 	$(PYTHON) -m black $* --check --diff
 	curlylint $*
 	cd $* && bash ../check-sql.sh
@@ -78,8 +78,7 @@ check-pip-requirements:
 		web_common \
 		auth \
 		batch \
-		ci \
-		memory
+		ci
 
 .PHONY: check-linux-pip-requirements
 check-linux-pip-requirements:
@@ -91,8 +90,7 @@ check-linux-pip-requirements:
 		web_common \
 		auth \
 		batch \
-		ci \
-		memory
+		ci
 
 .PHONY: install-dev-requirements
 install-dev-requirements:
@@ -103,8 +101,7 @@ install-dev-requirements:
 		-r web_common/pinned-requirements.txt \
 		-r auth/pinned-requirements.txt \
 		-r batch/pinned-requirements.txt \
-		-r ci/pinned-requirements.txt \
-		-r memory/pinned-requirements.txt \
+		-r ci/pinned-requirements.txt
 
 hail/python/hailtop/pinned-requirements.txt: hail/python/hailtop/requirements.txt
 	./generate-linux-pip-lockfile.sh hail/python/hailtop
@@ -130,9 +127,6 @@ batch/pinned-requirements.txt: web_common/pinned-requirements.txt batch/requirem
 ci/pinned-requirements.txt: web_common/pinned-requirements.txt ci/requirements.txt
 	./generate-linux-pip-lockfile.sh ci
 
-memory/pinned-requirements.txt: gear/pinned-requirements.txt memory/requirements.txt
-	./generate-linux-pip-lockfile.sh memory
-
 .PHONY: generate-pip-lockfiles
 generate-pip-lockfiles: hail/python/hailtop/pinned-requirements.txt
 generate-pip-lockfiles: hail/python/pinned-requirements.txt
@@ -142,7 +136,6 @@ generate-pip-lockfiles: web_common/pinned-requirements.txt
 generate-pip-lockfiles: auth/pinned-requirements.txt
 generate-pip-lockfiles: batch/pinned-requirements.txt
 generate-pip-lockfiles: ci/pinned-requirements.txt
-generate-pip-lockfiles: memory/pinned-requirements.txt
 
 $(HAILTOP_VERSION):
 	$(MAKE) -C hail python/hailtop/hail_version