Sept 23 upstream 3 (1c28203) #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rich` stacktraces will by default show the local variables at each level of scope, which is nice for debugging but can leak things like tokens. Best not to have that show up in logs or accidentally pasted into zulip
…ail-is#13214) This is a simple tidying refactoring to hide the `children` array from consumers of `BaseIR`. My main motivation is to make it easier to explore other ir data structure designs, and to migrate to a new design in the future, e.g. to allow for in-place mutation without requiring large-scale changes to every compiler pass, and to simplify how we encode binding structure.
…l-is#13215) Fixes hail-is#13205 Possible billing project states are defined in the database schema: ```mysql CREATE TABLE IF NOT EXISTS `billing_projects` ( `name` VARCHAR(100) NOT NULL, `name_cs` VARCHAR(100) NOT NULL COLLATE utf8mb4_0900_as_cs, `status` ENUM('open', 'closed', 'deleted') NOT NULL DEFAULT 'open', `limit` DOUBLE DEFAULT NULL, `msec_mcpu` BIGINT DEFAULT 0, PRIMARY KEY (`name`) ) ENGINE = InnoDB; CREATE INDEX `billing_project_status` ON `billing_projects` (`status`); CREATE UNIQUE INDEX `billing_project_name_cs` ON `billing_projects` (`name_cs`); CREATE INDEX `billing_project_name_cs_status` ON `billing_projects` (`name_cs`, `status`); ```
Co-authored-by: Chris Vittal <cvittal@broadinstitute.org>
Now that we have fully deterministic randomness, there is no need to prevent simplify from changing the partitioning.
Co-authored-by: Dan King <daniel.zidan.king@gmail.com>
) In order to start using Google or AAD access tokens instead of hail-minted tokens, we need to be able to identify a service account in the system by its UID at their identity provider. In Google, this UID is the `uniqueId` field of the Service Account. In AAD, it is the Service Principal Object ID. In an upcoming change, we'll update the user creation process to add this ID upon user creation, at which point we will be able to safely remove this code that updates existing records. I've marked this PR as `full-deploy` so the AUS folks can roll this commit out specifically before this column is relied on. This way we can safely remove the loop in a follow-up PR and know they will have run this code to populate the column.
jmarshall
approved these changes
Sep 8, 2023
Base automatically changed from
sept-23-upstream-2-31a0889
to
sept-23-upstream-1-c9db002
September 19, 2023 20:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #303