FIX: storage accounts weren't unique. Added prefix. Fixed zone bug in… #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flexible mysql db setup as well
illusional
approved these changes
May 16, 2023
illusional
pushed a commit
that referenced
this pull request
Jun 13, 2023
… flexible mysql db setup as well (#294)
illusional
pushed a commit
that referenced
this pull request
Jun 13, 2023
… flexible mysql db setup as well (#294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage accounts were no longer unique. I've added in a
storage_account_suffixargument in order to resolve this issue.The other bug was that the
zoneargument for the flexible mysql server no longer has any valid options in the Australia East region. I've commented it out with the error I noticed. Happy to clean up/remove that comment if we'd prefer it to not be there.