Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chlamydomonas reinhardtii genome #863

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

aays
Copy link
Contributor

@aays aays commented Apr 8, 2021

No demographic models for this one yet - I intend to do some digging after this, though, even if I'm not super confident there's many out there given how much Chlamy pop gen is only just taking off. But in either case, here's the reinhardtii genome!

An important note re: the recombination rate - sex takes place once every ~840 generations in the species (it's facultatively sexual), and the recombination rate estimates in here reflect that (e.g. they are r = rho / 2Ne, where rho was estimated directly from natural populations). To get 'true' physical recombination rate estimates, each of the values would be divided by the rate of sex, 0.001194 (explained further in the results/discussion here) which I've left as a note in the script. I figure that if simulating wild populations it makes more sense to have 'effective' recombination rates in there as opposed to the physical rates, since that would otherwise inflate the amount of recombination happening in the simulation.

If there's functionality to modify the rate of sex in a given simulation I think it'd make sense to encode the physical rates instead and save 0.001194 as a separate parameter. Happy to hear thoughts though!

Closes #828.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #863 (4542a73) into main (e01e42a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 4542a73 differs from pull request most recent head 939fb4f. Consider uploading reports for the commit 939fb4f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   99.39%   99.38%   -0.02%     
==========================================
  Files          74       58      -16     
  Lines        2498     2420      -78     
  Branches      285      284       -1     
==========================================
- Hits         2483     2405      -78     
  Misses          7        7              
  Partials        8        8              
Impacted Files Coverage Δ
stdpopsim/catalog/ChlRei/__init__.py 100.00% <100.00%> (ø)
stdpopsim/catalog/ChlRei/genome_data.py 100.00% <100.00%> (ø)
stdpopsim/catalog/ChlRei/species.py 100.00% <100.00%> (ø)
stdpopsim/catalog/DroMel/species.py 100.00% <0.00%> (ø)
stdpopsim/catalog/HelMel/species.py
stdpopsim/catalog/AedAeg/__init__.py
stdpopsim/catalog/AedAeg/genome_data.py
stdpopsim/catalog/AnaPla/__init__.py
stdpopsim/catalog/AnoGam/__init__.py
stdpopsim/catalog/AnoGam/demographic_models.py
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01e42a...939fb4f. Read the comment docs.

@petrelharp
Copy link
Contributor

Agreed we should do the selfing rate right - see #857.

@jeromekelleher
Copy link
Member

LGTM - can you squash the commits please @aays? https://stdpopsim.readthedocs.io/en/latest/development.html#rebasing

@aays
Copy link
Contributor Author

aays commented Apr 9, 2021

Sounds good @jeromekelleher - on it! I've just heard back from Rob about per-chromosome mutation rates though, so I'm going to nab those as well before squashing the commits.

Re: selfing rate, that sounds good as well - it's less so selfing and more infrequent sex altogether (Chlamy is happy to have many mitotic generations before periodically outcrossing) but I figure the same idea applies in that that's already baked into the estimate of Ne.

@jeromekelleher
Copy link
Member

Looks good! Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Chlamydomonas reinhardtii to catalogue
3 participants