Решетников Алексей, ИТМО DWS, stage 2 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
src/main/java/ru/vk/itmo/test/reshetnikovaleksei/HttpServerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/vk/itmo/test/reshetnikovaleksei/HttpServerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/vk/itmo/test/reshetnikovaleksei/ExecutorServiceFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/vk/itmo/test/reshetnikovaleksei/HttpServerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/vk/itmo/test/reshetnikovaleksei/ExecutorServiceFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/vk/itmo/test/reshetnikovaleksei/ExecutorServiceFactory.java
Outdated
Show resolved
Hide resolved
urbanchef
reviewed
Mar 9, 2024
src/main/java/ru/vk/itmo/test/reshetnikovaleksei/ServiceImpl.java
Outdated
Show resolved
Hide resolved
urbanchef
reviewed
Mar 9, 2024
|
|
||
| ## Выводы | ||
|
|
||
| При выполнении `stage1` ноутбук был достаточно уставшим (непрерывная работа в течение нескольких дней). При выполнении |
There was a problem hiding this comment.
Здесь должен быть вывод по существу: как можно улучшить систему, почему увеличение потоков увеличило/уменьшило производительность, как повлиял выбор переменных (queue size, релизация очереди и тп) на производительность, в чем особенности. Разного рода "энтропию", такую как "усталость" железа, в тестах производительности необходимо исключать.
|
9/15 - вывод не по существу. Есть замечания по коду |
urbanchef
approved these changes
Mar 15, 2024
GenryEden
pushed a commit
to GenryEden/2024-highload-dht
that referenced
this pull request
Mar 20, 2024
* stage2 * fix * codeclimate * codeclimate polis-vk#2 * fixes * report * graceful shutdown --------- Co-authored-by: Roman Mushchinskii <31738033+urbanchef@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.