HW1 Чеботин Александр (ITMO DWS) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Тест один флакает почему-то |
Значит, есть баг. Какие есть идеи? 11:06:44.653 [NIO Selector #11] ERROR one.nio.net.Session -- Cannot process session from 127.0.0.1
java.lang.IndexOutOfBoundsException: Out of bound access on segment MemorySegment{ heapBase: Optional[[B@7885006c] address:0 limit: 16 }; new offset = 128; new length = 8
at java.base/jdk.internal.foreign.AbstractMemorySegmentImpl.outOfBoundException(AbstractMemorySegmentImpl.java:426)
at java.base/jdk.internal.foreign.AbstractMemorySegmentImpl.apply(AbstractMemorySegmentImpl.java:407)
at java.base/jdk.internal.foreign.AbstractMemorySegmentImpl.apply(AbstractMemorySegmentImpl.java:69)
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:124)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:448)
at java.base/jdk.internal.foreign.AbstractMemorySegmentImpl.checkBounds(AbstractMemorySegmentImpl.java:396)
at java.base/jdk.internal.foreign.AbstractMemorySegmentImpl.checkAccess(AbstractMemorySegmentImpl.java:356)
at java.base/java.lang.invoke.VarHandleSegmentAsLongs.checkAddress(VarHandleSegmentAsLongs.java:81)
at java.base/java.lang.invoke.VarHandleSegmentAsLongs.get(VarHandleSegmentAsLongs.java:108)
at ru.vk.itmo.test.chebotinalexandr.dao.MurmurHash.getBlock(MurmurHash.java:153)
at ru.vk.itmo.test.chebotinalexandr.dao.MurmurHash.hash64(MurmurHash.java:51)
at ru.vk.itmo.test.chebotinalexandr.dao.BloomFilter.sstableMayContain(BloomFilter.java:58)
at ru.vk.itmo.test.chebotinalexandr.dao.NotOnlyInMemoryDao.getFromDisk(NotOnlyInMemoryDao.java:107)
at ru.vk.itmo.test.chebotinalexandr.dao.NotOnlyInMemoryDao.get(NotOnlyInMemoryDao.java:100)
at ru.vk.itmo.test.chebotinalexandr.dao.NotOnlyInMemoryDao.get(NotOnlyInMemoryDao.java:32)
at ru.vk.itmo.test.chebotinalexandr.StorageServer.get(StorageServer.java:65)
at RequestHandler0_get.handleRequest(Unknown Source)
at one.nio.http.HttpServer.handleRequest(HttpServer.java:66)
at one.nio.http.HttpSession.handleParsedRequest(HttpSession.java:137)
at one.nio.http.HttpSession.processHttpBuffer(HttpSession.java:198)
at one.nio.http.HttpSession.processRead(HttpSession.java:77)
at one.nio.net.Session.process(Session.java:222)
at one.nio.server.SelectorThread.run(SelectorThread.java:70)
java.io.IOException: HTTP/1.1 header parser received no bytes
at java.net.http/jdk.internal.net.http.HttpClientImpl.send(HttpClientImpl.java:964)
at java.net.http/jdk.internal.net.http.HttpClientFacade.send(HttpClientFacade.java:133)
at ru.vk.itmo.ServiceInfo.get(ServiceInfo.java:38)
at ru.vk.itmo.SingleNodeTest.restart(SingleNodeTest.java:233)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.io.IOException: HTTP/1.1 header parser received no bytes
at java.net.http/jdk.internal.net.http.common.Utils.wrapWithExtraDetail(Utils.java:388)
at java.net.http/jdk.internal.net.http.Http1Response$HeadersReader.onReadError(Http1Response.java:590)
at java.net.http/jdk.internal.net.http.Http1AsyncReceiver.checkForErrors(Http1AsyncReceiver.java:302)
at java.net.http/jdk.internal.net.http.Http1AsyncReceiver.flush(Http1AsyncReceiver.java:268)
at java.net.http/jdk.internal.net.http.common.SequentialScheduler$LockingRestartableTask.run(SequentialScheduler.java:182)
at java.net.http/jdk.internal.net.http.common.SequentialScheduler$CompleteRestartableTask.run(SequentialScheduler.java:149)
at java.net.http/jdk.internal.net.http.common.SequentialScheduler$SchedulableTask.run(SequentialScheduler.java:207)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.io.EOFException: EOF reached while reading
at java.net.http/jdk.internal.net.http.Http1AsyncReceiver$Http1TubeSubscriber.onComplete(Http1AsyncReceiver.java:601)
at java.net.http/jdk.internal.net.http.SocketTube$InternalReadPublisher$ReadSubscription.signalCompletion(SocketTube.java:648)
at java.net.http/jdk.internal.net.http.SocketTube$InternalReadPublisher$InternalReadSubscription.read(SocketTube.java:853)
at java.net.http/jdk.internal.net.http.SocketTube$SocketFlowTask.run(SocketTube.java:181)
at java.net.http/jdk.internal.net.http.common.SequentialScheduler$SchedulableTask.run(SequentialScheduler.java:207)
at java.net.http/jdk.internal.net.http.common.SequentialScheduler.runOrSchedule(SequentialScheduler.java:280)
at java.net.http/jdk.internal.net.http.common.SequentialScheduler.runOrSchedule(SequentialScheduler.java:233)
at java.net.http/jdk.internal.net.http.SocketTube$InternalReadPublisher$InternalReadSubscription.signalReadable(SocketTube.java:782)
at java.net.http/jdk.internal.net.http.SocketTube$InternalReadPublisher$ReadEvent.signalEvent(SocketTube.java:965)
at java.net.http/jdk.internal.net.http.SocketTube$SocketFlowEvent.handle(SocketTube.java:253)
at java.net.http/jdk.internal.net.http.HttpClientImpl$SelectorManager.handleEvent(HttpClientImpl.java:1467)
at java.net.http/jdk.internal.net.http.HttpClientImpl$SelectorManager.lambda$run$3(HttpClientImpl.java:1412)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.net.http/jdk.internal.net.http.HttpClientImpl$SelectorManager.run(HttpClientImpl.java:1412) |
Благодаря тесту выявился баг в моей реализации Dao, о существовании которого в прошлом семестре я даже не знал. Исправлю |
|
Нужно пофиксить замечания от CodeClimate. |
А можно ли отключить замечание CodeClimate на fall-through? В реализации MurmurHash есть одно из редких применений fall-through внутри switch конструкции. |
Да, попробуете отключить в рамках этого PR через |
Да, отключил |
incubos
approved these changes
Feb 25, 2024
| function request() | ||
| headers = { } | ||
| headers["Host"] = "localhost:8080" | ||
| return wrk.format("GET", "/hello", headers) |
| } | ||
|
|
||
| private static List<Integer> getRandomArray() { | ||
| ArrayList<Integer> entries = new ArrayList<>(ENTRIES_IN_DB); |
There was a problem hiding this comment.
int[] был бы сильно компактнее.
Comment on lines
+60
to
+62
| if (id == null || id.isEmpty()) { | ||
| return new Response(Response.BAD_REQUEST, Response.EMPTY); | ||
| } |
| return new Response(Response.BAD_REQUEST, Response.EMPTY); | ||
| } | ||
|
|
||
| Entry<MemorySegment> entry = dao.get(fromString(id)); |
There was a problem hiding this comment.
Здесь и ниже не хватает обработки возможных исключений из DAO.
| } | ||
|
|
||
| @Path(PATH) | ||
| public Response post(@Param("id") String id) { |
There was a problem hiding this comment.
Не только POST же? Есть много других интересных HTTP методов...
There was a problem hiding this comment.
Это да) просто название метода неудачное, а так при любом http запросе отличном от GET/PUT/DELETE запрос обработается в этом методе, в том числе для OPTIONS, PATCH, HEAD…
|
|
||
| ``` | ||
|
|
||
| Гистограмма, на которой видна деградация с течением времени: |
There was a problem hiding this comment.
Это же распределение времён ответа. Что значит "с течением времени"?
| ``` | ||
|  | ||
|
|
||
| Видим что среднее Latency - 0.81 ms. |
There was a problem hiding this comment.
Как мы обсуждали на занятиях, вместо среднего правильнее смотреть на перцентили.
|
|
||
| Detailed Percentile spectrum тут не нужен, и так видно, что база просто моментально захлебнулась таким количеством бинарных поисков. | ||
|
|
||
| Снижением rps была определена точка разладки, в этом случае она составляет 10k rps. Возьмем стабильную 7.5k rps: |
There was a problem hiding this comment.
Откуда 10К rps? В листинге выше выдержали только 7.2К rps.
|
|
||
|  | ||
|
|
||
| Видно что много аллокаций приходится на SSTablesStorage.write - это как раз сброс данных с memtable на диск. |
There was a problem hiding this comment.
На flamegraph видно, что почти все аллокации при этом возникают в SSTablesStorage.getPaths() -- можно их устранить? Они действительно необходимы?
|
|
||
|  | ||
|
|
||
| Ярко выраженная затрата времени на JIT-компиляцию, что вызывает задержку. Также видим задержку увеличивает также flush (метод SSTablesStorage.write). |
There was a problem hiding this comment.
Здесь неправильно говорить о "задержке" -- мы видим, на что тратятся циклы процессора. Почему упоминается JIT, но нет ни слова про "слона" -- как и выше SSTablesStorage.getPaths(). Можно его соптимизировать? Действительно ли необходимо на каждый запрос тратить столько CPU на построение путей, которые почти не меняются?
lehatheslayer
added a commit
to lehatheslayer/2024-highload-dht
that referenced
this pull request
Feb 29, 2024
urbanchef
added a commit
that referenced
this pull request
Mar 15, 2024
* stage2 * fix * codeclimate * codeclimate #2 * fixes * report * graceful shutdown --------- Co-authored-by: Roman Mushchinskii <31738033+urbanchef@users.noreply.github.com>
GenryEden
pushed a commit
to GenryEden/2024-highload-dht
that referenced
this pull request
Mar 20, 2024
* stage2 * fix * codeclimate * codeclimate polis-vk#2 * fixes * report * graceful shutdown --------- Co-authored-by: Roman Mushchinskii <31738033+urbanchef@users.noreply.github.com>
atimofeyev
added a commit
that referenced
this pull request
Apr 18, 2024
* stage2 * fix * codeclimate * codeclimate #2 * fixes * report * graceful shutdown * stage3 * style * style * style * style * style * style * style * fixes * report * style * stage 4 * style * style * style * report --------- Co-authored-by: Vadim Tsesko <incubos@users.noreply.github.com> Co-authored-by: atimofeyev <andrey.timofeyev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.