CI: Fix windows tests disk space failure #3122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2783
Problem
The windows tests were failing due to insufficient disk space because of cargo management on the
D:
drive. Unlike other OS options, the windows GHA option uses theD:
drive which has less capacity than theC:
drive.Solution
Use
Swatinem/rust-cache@v1
or similar logic to manage caching depsNOTE: I modified the
on
to trigger this GHA in order to demonstrate the passing test. Before merging I can pull this out.Other
While looking into this I noticed:
windows-2019
is often associated with random issues (changed towindows-latest
in this PR)I'm curious how well this will hold up over time since nightly is used here. In case there's a need to fallback to the workaround, something along these lines (+ some cleaning logic) could probably be used:
Note the cloning and
checkout
need to be further validated.Other Resources: