Refactor azure storage with crate updates #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @roeap you can remove |
|
Thanks @Blajda - always happy to be able to slim down dependencies 😆 |
wjones127
previously approved these changes
Jun 17, 2022
|
@wjones127 - we saw failing CI due to windows runners running out of disk space. Based on pola-rs/polars#3122 (comment) I switched to using Swatinem/rust-cache, which seems to do some nice things around managing cache size and utilization. Right now builds are passing again, but this could just be related to using a "fresh" cache, we'll have to keep an eye on it. Could you have another look? |
wjones127
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the latest version of the azure SDKs some annoyances got fixed. specifically, list now returns something
Sendable, which allows us to significantly simplify thelist_objsmethod. Secondly the errors are no longer a deeply nested nightmare 😆.Also added a test for validating that service principal access works (#609) - currently i am guessing the issues encountered there are more related to #643
Related Issue(s)
validate the SP access works for #609
Documentation