Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add negative slicing to new streaming multiscan #21219

Merged

Conversation

coastalwhite
Copy link
Collaborator

Built on #21191.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Feb 12, 2025
@coastalwhite coastalwhite force-pushed the feat/new-streaming-multiscan-neg-slice branch from e67607e to 4806c32 Compare February 13, 2025 12:45
@coastalwhite coastalwhite marked this pull request as ready for review February 13, 2025 13:36
@coastalwhite coastalwhite force-pushed the feat/new-streaming-multiscan-neg-slice branch from 0ecb637 to b4d75a7 Compare February 14, 2025 14:48
@coastalwhite coastalwhite force-pushed the feat/new-streaming-multiscan-neg-slice branch from b4d75a7 to aa2630d Compare February 17, 2025 16:45
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 90.76923% with 42 lines in your changes missing coverage. Please review.

Project coverage is 79.90%. Comparing base (d6bb315) to head (38ef3a6).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
...s/polars-stream/src/nodes/io_sources/multi_scan.rs 91.80% 35 Missing ⚠️
.../polars-stream/src/nodes/io_sources/parquet/mod.rs 66.66% 3 Missing ⚠️
crates/polars-stream/src/nodes/io_sources/mod.rs 84.61% 2 Missing ⚠️
crates/polars-stream/src/nodes/io_sources/csv.rs 66.66% 1 Missing ⚠️
crates/polars-stream/src/nodes/io_sources/ipc.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21219      +/-   ##
==========================================
- Coverage   79.92%   79.90%   -0.02%     
==========================================
  Files        1596     1596              
  Lines      228746   228705      -41     
  Branches     2616     2618       +2     
==========================================
- Hits       182823   182754      -69     
- Misses      45324    45352      +28     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite force-pushed the feat/new-streaming-multiscan-neg-slice branch 2 times, most recently from e69dadc to 9f16ec4 Compare February 18, 2025 12:33
@coastalwhite coastalwhite force-pushed the feat/new-streaming-multiscan-neg-slice branch from d227dbe to c1d2d6b Compare February 19, 2025 15:57
@coastalwhite coastalwhite merged commit d2a6b8b into pola-rs:main Feb 20, 2025
26 checks passed
@coastalwhite coastalwhite deleted the feat/new-streaming-multiscan-neg-slice branch February 20, 2025 10:26
@c-peters c-peters added the accepted Ready for implementation label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants