Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add positive slice for new streaming MultiScan #21191

Merged

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@coastalwhite coastalwhite changed the title Feat/new streaming multiscan slice feat: Add positive slice for new streaming MultiScan Feb 11, 2025
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Feb 11, 2025
@coastalwhite coastalwhite force-pushed the feat/new-streaming-multiscan-slice branch from cbf1b25 to 2d4a575 Compare February 11, 2025 14:43
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 90.77491% with 25 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (9bcff72) to head (7442f06).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...s/polars-stream/src/nodes/io_sources/multi_scan.rs 93.36% 15 Missing ⚠️
crates/polars-stream/src/nodes/io_sources/csv.rs 76.19% 5 Missing ⚠️
crates/polars-mem-engine/src/predicate.rs 0.00% 3 Missing ⚠️
crates/polars-stream/src/nodes/io_sources/mod.rs 90.90% 1 Missing ⚠️
...polars-stream/src/nodes/io_sources/parquet/init.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21191      +/-   ##
==========================================
+ Coverage   79.75%   79.86%   +0.10%     
==========================================
  Files        1593     1593              
  Lines      228119   228268     +149     
  Branches     2600     2600              
==========================================
+ Hits       181947   182298     +351     
+ Misses      45575    45373     -202     
  Partials      597      597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite force-pushed the feat/new-streaming-multiscan-slice branch from a61819a to 7442f06 Compare February 13, 2025 10:42
@coastalwhite coastalwhite merged commit ed19c73 into pola-rs:main Feb 13, 2025
27 checks passed
@coastalwhite coastalwhite deleted the feat/new-streaming-multiscan-slice branch February 13, 2025 12:43
@c-peters c-peters added the accepted Ready for implementation label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants