fix: Output index type instead of u32 for sum_horizontal with boolean inputs
#20531
+45
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcrumiller
changed the title
sum_horizontal with boolean inputssum_horizontal with boolean inputs
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20531 +/- ##
=======================================
Coverage 79.05% 79.05%
=======================================
Files 1564 1564
Lines 220627 220628 +1
Branches 2502 2502
=======================================
+ Hits 174413 174416 +3
+ Misses 45640 45638 -2
Partials 574 574 ☔ View full report in Codecov by Sentry. |
mcrumiller
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
reviewed
Jan 3, 2025
| @@ -221,16 +255,7 @@ pub fn sum_horizontal( | |||
|
|
|||
| // If we have any null columns and null strategy is not `Ignore`, we can return immediately. | |||
| if !ignore_nulls && non_null_cols.len() < columns.len() { | |||
| // We must first determine the correct return dtype. | |||
| let return_dtype = match dtypes_to_supertype(non_null_cols.iter().map(|c| c.dtype()))? { | |||
| DataType::Boolean => DataType::UInt32, | |||
There was a problem hiding this comment.
Can't we leave this code? (replacing indextype). I don't see much benefit in the extra functions that do an extra vec alloc and are only used once.
There was a problem hiding this comment.
Yes, sorry--I mixed up some of the temporal mean_horizontal code with this PR. Will fix.
I may have to re-introduce something similar in that PR but we can do that there.
ritchie46
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.