Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add mean_horizontal for temporals #20522

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Add mean_horizontal for temporals #20522

wants to merge 4 commits into from
+282 −33

Conversation

mcrumiller
Copy link
Contributor

@mcrumiller mcrumiller commented Jan 2, 2025 •
edited
Loading

Closes #20313.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 2, 2025
@mcrumiller mcrumiller marked this pull request as ready for review January 2, 2025 02:57
@ritchie46
Copy link
Member

Also fixed the Boolean -> IdxType for sums since it was super minor.

can you split that out?

@mcrumiller
Copy link
Contributor Author

Also fixed the Boolean -> IdxType for sums since it was super minor.

can you split that out?

Yup.

@mcrumiller mcrumiller marked this pull request as draft January 2, 2025 14:43
@mcrumiller
Copy link
Contributor Author

@ritchie46 #20531.

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.45299% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (da0b589) to head (e7e5a60).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-ops/src/series/ops/horizontal.rs 90.56% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20522      +/-   ##
==========================================
+ Coverage   79.00%   79.01%   +0.01%     
==========================================
  Files        1564     1564              
  Lines      220619   220707      +88     
  Branches     2502     2502              
==========================================
+ Hits       174300   174396      +96     
+ Misses      45745    45738       -7     
+ Partials      574      573       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcrumiller mcrumiller marked this pull request as ready for review January 3, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mean_horizontal raises on temporals
2 participants
@mcrumiller @ritchie46