perf: Generalize the arg_sort fast path onto Column
#20437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the implementation of `arg_sort` take the fast path in `Column` before ever going into a specific SeriesTrait implementor. This now makes that every type has the same fast path that gets taken when sorted. It also now allows taking the fast path when `maintain_order=True`. This PR needed to adjust some tests because they wrongly assumed things about the output order of the sorting when `maintain_order=False`.
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
coastalwhite
changed the title
arg_sort fast path onto Column.arg_sort fast path onto Column
github-actions
bot
added
performance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20437 +/- ##
==========================================
- Coverage 79.01% 79.00% -0.02%
==========================================
Files 1562 1563 +1
Lines 220177 220463 +286
Branches 2488 2488
==========================================
+ Hits 173980 174181 +201
- Misses 45624 45709 +85
Partials 573 573 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the implementation of
arg_sorttake the fast path inColumnbefore ever going into a specific SeriesTrait implementor. This now makes that every type has the same fast path that gets taken when sorted. It also now allows taking the fast path whenmaintain_order=True.This PR needed to adjust some tests because they wrongly assumed things about the output order of the sorting when
maintain_order=False.There are some streaming tests that need to be disabled because of #20440.