Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix return type for add_business_days, millennium, century and combine methods in Series.dt namespace #20436

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

Terrigible
Copy link
Contributor

Return type for Series.dt.add_business_days's type annotation was fixed in #20402, but not its docstring. This PR fixes the docstring.

This PR also fixes the return types for millennium, century and combine in the Series.dt namespace.

Return type was fixed in pola-rs#20402 for method type annotation but not docstring. This commit fixes the docstring
Fix return type for `millennium`, `century` and `combine` methods
@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.73%. Comparing base (93ceacc) to head (59b2994).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #20436       +/-   ##
===========================================
- Coverage   79.01%   58.73%   -20.28%     
===========================================
  Files        1562     1562               
  Lines      220177   220177               
  Branches     2488     2488               
===========================================
- Hits       173980   129331    -44649     
- Misses      45624    90273    +44649     
  Partials      573      573               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Terrigible , much appreciated!

@MarcoGorelli MarcoGorelli merged commit bdc597f into pola-rs:main Dec 24, 2024
15 checks passed
@Terrigible Terrigible deleted the fix/series-dt-return-types branch December 25, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants