Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix return type of Series.dt.add_business_days #20402

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

Terrigible
Copy link
Contributor

The return type of Series.dt.add_business_days should be Series, not Expr

>>> import polars as pl
>>> import datetime

>>> type(
    pl.Series("date", [datetime.date(2024, 12, 23)]).dt.add_business_days(
        1, roll="forward"
    )
)
<class 'polars.series.series.Series'>

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (127f590) to head (6b0b120).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20402      +/-   ##
==========================================
- Coverage   78.96%   78.96%   -0.01%     
==========================================
  Files        1562     1562              
  Lines      220078   220078              
  Branches     2480     2480              
==========================================
- Hits       173793   173789       -4     
- Misses      45714    45718       +4     
  Partials      571      571              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Terrigible !

@MarcoGorelli MarcoGorelli merged commit 54860b9 into pola-rs:main Dec 22, 2024
15 checks passed
Terrigible added a commit to Terrigible/polars that referenced this pull request Dec 24, 2024
Changed the type annotation in pola-rs#20402 but forgot to change the docstring
Terrigible added a commit to Terrigible/polars that referenced this pull request Dec 24, 2024
Return type was fixed in pola-rs#20402 for method type annotation but not docstring. This commit fixes the docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants