Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr(python): Deprecate LazyFrame.fetch #17278

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jun 28, 2024

Closes #17267.

Removes a long-standing footgun ... 👌


Double-checking if we want to deprecate, or if we should make it a breaking change to clean things up for the 1.0 (in which case we can just add the breaking tag and merge). Given its status as a debug-only function that already has warnings on it, this probably isn't unreasonable - by definition it can't be used in production workflows 🤔

Update: deprecation it is!

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.71%. Comparing base (d444b79) to head (cd85460).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/polars/lazyframe/frame.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17278      +/-   ##
==========================================
- Coverage   80.72%   80.71%   -0.02%     
==========================================
  Files        1475     1475              
  Lines      193162   193165       +3     
  Branches     2751     2752       +1     
==========================================
- Hits       155922   155904      -18     
- Misses      36732    36753      +21     
  Partials      508      508              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

We should tag breaking, but it's fine to undraft.

@alexander-beedie
Copy link
Collaborator Author

We should tag breaking, but it's fine to undraft.

@stinodego has convinced me to deprecate first, as it takes so little effort to do so :)

@alexander-beedie alexander-beedie marked this pull request as ready for review June 29, 2024 19:39
@alexander-beedie alexander-beedie changed the title feat(python): Make debug fetch function private depr(python): Make debug fetch function private Jun 29, 2024
@github-actions github-actions bot added the deprecation Add a deprecation warning to outdated functionality label Jun 29, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few minor remarks and this can go in!

py-polars/polars/lazyframe/frame.py Outdated Show resolved Hide resolved
py-polars/polars/lazyframe/frame.py Show resolved Hide resolved
@ritchie46 ritchie46 merged commit a2cea70 into pola-rs:main Jun 30, 2024
15 checks passed
@stinodego stinodego changed the title depr(python): Make debug fetch function private depr(python): Deprecate LazyFrame.fetch Jun 30, 2024
@alexander-beedie alexander-beedie deleted the private-fetch branch June 30, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Add a deprecation warning to outdated functionality enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate LazyFrame.fetch
3 participants