-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depr(python): Deprecate LazyFrame.fetch
#17278
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17278 +/- ##
==========================================
- Coverage 80.72% 80.71% -0.02%
==========================================
Files 1475 1475
Lines 193162 193165 +3
Branches 2751 2752 +1
==========================================
- Hits 155922 155904 -18
- Misses 36732 36753 +21
Partials 508 508 ☔ View full report in Codecov by Sentry. |
We should tag breaking, but it's fine to undraft. |
1e92eb0
to
adc739d
Compare
@stinodego has convinced me to deprecate first, as it takes so little effort to do so :) |
fetch
function privatefetch
function private
adc739d
to
932fc32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few minor remarks and this can go in!
fetch
function privateLazyFrame.fetch
Closes #17267.
Removes a long-standing footgun ... 👌
Double-checking if we want to deprecate, or if we should make it a breaking change to clean things up for the 1.0 (in which case we can just add the breaking tag and merge). Given its status as a debug-only function that already has warnings on it, this probably isn't unreasonable - by definition it can't be used in production workflows 🤔
Update: deprecation it is!