Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate LazyFrame.fetch #17267

Closed
stinodego opened this issue Jun 28, 2024 · 0 comments · Fixed by #17278
Closed

Deprecate LazyFrame.fetch #17267

stinodego opened this issue Jun 28, 2024 · 0 comments · Fixed by #17278
Assignees
Labels
accepted Ready for implementation deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Milestone

Comments

@stinodego
Copy link
Member

stinodego commented Jun 28, 2024

Users should use collect instead. There are some gotchas that make fetch confusing for users. It should not be part of the public API.

So we should:

  1. Add a private equivalent, _fetch, which devs can continue to use for debugging if needed.
  2. Deprecate fetch with 1.0 and point it to _fetch.
@stinodego stinodego added python Related to Python Polars deprecation Add a deprecation warning to outdated functionality labels Jun 28, 2024
@stinodego stinodego added this to the 1.0.0 milestone Jun 28, 2024
@stinodego stinodego added the accepted Ready for implementation label Jun 28, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog Jun 28, 2024
@stinodego stinodego moved this from Ready to Next in Backlog Jun 28, 2024
@github-project-automation github-project-automation bot moved this from Next to Done in Backlog Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants