-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Rename Utf8
data type to String
, keep Utf8
as alias
#13257
Conversation
Does |
No, it returns an object though that behaves exactly like EDIT: Yeah if we accept that, things become much nicer 👍 we can just do |
Great! That makes it behave more like an alias. |
f01d8cb
to
98ca05d
Compare
478b4a1
to
60f2ca0
Compare
class Utf8(DataType): | ||
class String(DataType): | ||
"""UTF-8 encoded string type.""" | ||
|
||
|
||
# Allow Utf8 as an alias for String | ||
Utf8 = String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the core of this PR.
Have you done the datatypes mentioned in the user-guide? Feel free to merge this one. Especially now it is a proper alias it seems fine to me. |
Hadn't done that yet. Updated references in the user guide now. Will merge if CI is green! |
I added the new
String
data type in three steps:Utf8
used everywhere).Utf8
toString
in test suite too.