Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user-agent is not string in logs #792

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

denelvis
Copy link
Contributor

@denelvis denelvis commented Dec 6, 2022

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine, or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable, and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

@shpingalet007 shpingalet007 changed the title fix(app.js): add stringify to logger fix: user-agent is not string in logs Dec 7, 2022
@shpingalet007 shpingalet007 added the contribution type: 🐛 fix Something isn't working label Dec 7, 2022
@shpingalet007 shpingalet007 added this to the Next release milestone Dec 7, 2022
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality checked.

@denelvis, please don't forgot to fill the checklist in PR. It is important for seniors to be able to understand the situation. Now I'll accept it, as I see that it's small, but next time I'll wait the checklist before merging. Thanks.

@zanhesl, the #762 wasn't checked well on logger before merge.

@shpingalet007 shpingalet007 merged commit 8812bf8 into pocketnetteam:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution type: 🐛 fix Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants