Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: logger functionality #762

Merged
merged 11 commits into from
Nov 30, 2022

Conversation

denelvis
Copy link
Contributor

@denelvis denelvis commented Nov 17, 2022

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

  • [...]

Other comments:

...

Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localstorage data would not be logged. It contains crucial security data of user

@shpingalet007 shpingalet007 added the contribution type: ✨ feature New feature or request label Nov 17, 2022
@shpingalet007 shpingalet007 changed the title Feat/logger improve patch: logger functionality Nov 17, 2022
@shpingalet007 shpingalet007 added contribution type: 🧩 patch Pull request that is considered as patch and removed contribution type: ✨ feature New feature or request labels Nov 17, 2022
@shpingalet007 shpingalet007 added this to the Next release milestone Nov 17, 2022
@denelvis denelvis force-pushed the feat/logger_improve branch from 50b9a5d to c9b6e90 Compare November 18, 2022 13:57
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this PR can be accepted, linting edits in js/app.js need to be removed

@shpingalet007 shpingalet007 marked this pull request as ready for review November 30, 2022 10:53
@auto-assign auto-assign bot requested a review from shpingalet007 November 30, 2022 10:53
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality checked

@shpingalet007 shpingalet007 merged commit b6fc404 into pocketnetteam:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution type: 🧩 patch Pull request that is considered as patch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants