Issue 290 #293
Merged
Issue 290 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(plusjade#290) solution: if page.theme.name unavailable (empty) use layout.theme.name
pauldmccarthy
added a commit
to pauldmccarthy/pauldmccarthy.github.com
that referenced
this pull request
Feb 23, 2016
issue (plusjade/jekyll-bootstrap#293). Not sure if it will work yet.
andtorg
added a commit
to andtorg/andtorg.github.io
that referenced
this pull request
Mar 14, 2016
corneadoug
added a commit
to corneadoug/incubator-zeppelin
that referenced
this pull request
Sep 7, 2016
bzz
pushed a commit
to bzz/incubator-zeppelin
that referenced
this pull request
Sep 7, 2016
Backport plusjade/jekyll-bootstrap#293 + add .html to `pages_list` links
asfgit
pushed a commit
to apache/zeppelin
that referenced
this pull request
Sep 7, 2016
### What is this PR for? In recent changes download links were broken on the project website ### What type of PR is it? Hot Fix ### Todos * [x] - update Jekyll version * [x] - update documentation, with `--safe` removed * [x] - add "production" mode flag though `JEKYLL_ENV` aka plusjade/jekyll-bootstrap#84 ### How should this be tested? ``` bundle update JEKYLL_ENV=production bundle exec jekyll serve ``` ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes, it was Author: Alexander Bezzubov <bzz@apache.org> Author: Damien CORNEAU <corneadoug@gmail.com> Author: Alexander <abezzubov@nflabs.com> Closes #1410 from bzz/fix-download-links and squashes the following commits: 2b04e4a [Alexander] Merge pull request #11 from corneadoug/fix/otherRenderingIssues f774bb0 [Damien CORNEAU] Add extension to pages_list links 68f4d64 [Damien CORNEAU] Backport plusjade/jekyll-bootstrap#293 09f770e [Alexander Bezzubov] Add missing dependency and update deprecated config f270a43 [Alexander Bezzubov] Update Jekyll in order to use JEKYLL_ENV 45bf884 [Alexander Bezzubov] Backport of plusjade/jekyll-bootstrap#262 for website
mrdougwright
pushed a commit
to mrdougwright/mrdougwright.github.io
that referenced
this pull request
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default ASSET_PATH fails for latest jekyll version #290
(#290)
solution: if page.theme.name unavailable (empty) use layout.theme.name