Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download links #1410

Closed
wants to merge 6 commits into from
Closed

Fix download links #1410

wants to merge 6 commits into from

Conversation

bzz
Copy link
Member

@bzz bzz commented Sep 7, 2016

What is this PR for?

In recent changes download links were broken on the project website

What type of PR is it?

Hot Fix

Todos

How should this be tested?

bundle update
JEKYLL_ENV=production bundle exec jekyll serve

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Yes, it was

@corneadoug
Copy link
Contributor

@bzz Tested:

  • Locally
  • With Production Flag
  • With SVN doc folder

LGTM, let's try to get it merged fast since it is a Hot Fix.

Documentation change for that PR is handled in #1405

@AhyoungRyu
Copy link
Contributor

Yeah tested too and it works as expected. LGTM 👍
Let's merge this quickly as a Hotfix.

@bzz
Copy link
Member Author

bzz commented Sep 7, 2016

Thank you guys for for the prompt reviews!

Merging it in.

@asfgit asfgit closed this in 97810a0 Sep 7, 2016
@bzz bzz deleted the fix-download-links branch September 7, 2016 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants