-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace prettier with biome #598
Conversation
WalkthroughThe project has transitioned from using Prettier for code formatting to adopting Biome, an advanced tool for linting and formatting. This change involves updating the pre-commit configuration to point to the new Biome repository and renaming the relevant hook. An additional dependency on a specific version of Biome has also been introduced, enhancing the project's code quality practices. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .pre-commit-config.yaml (1 hunks)
Additional comments not posted (3)
.pre-commit-config.yaml (3)
95-95
: Verify the new repository URL.Ensure that the new repository URL
https://github.com/biomejs/pre-commit
is correct and accessible.Verification successful
The new repository URL is correct and accessible.
The repository URL
https://github.com/biomejs/pre-commit
returned a status code 200, indicating it is accessible.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new repository URL for Biome pre-commit hook. # Test: Check if the repository is accessible. Expect: HTTP status code 200. curl -o /dev/null -s -w "%{http_code}\n" https://github.com/biomejs/pre-commitLength of output: 84
98-98
: Verify the new hook ID.Ensure that the new hook ID
biome-lint
is correct and matches the expected ID in the Biome repository.Verification successful
The new hook ID
biome-lint
is correct.The hook ID
biome-lint
is present in the Biome repository, confirming that the change in the.pre-commit-config.yaml
file is accurate.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new hook ID for Biome pre-commit hook. # Test: Check if the hook ID `biome-lint` is present in the Biome repository. curl -s https://raw.githubusercontent.com/biomejs/pre-commit/main/.pre-commit-hooks.yaml | grep 'id: biome-lint'Length of output: 133
99-99
: Verify the additional dependency.Ensure that the additional dependency
@biomejs/biome@1.8.3
is correct and necessary for the Biome pre-commit hook.Verification successful
The additional dependency
@biomejs/biome@1.8.3
is correctly specified and necessary for thebiome-lint
pre-commit hook.
- The
.pre-commit-config.yaml
file includes a configuration for thebiome-lint
hook that requires this dependency.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the additional dependency for Biome pre-commit hook. # Test: Check if the specified version of the additional dependency is available. npm show @biomejs/biome@1.8.3 versionLength of output: 110
Script:
#!/bin/bash # Description: Search for references to @biomejs/biome in the codebase to verify its necessity. # Find all occurrences of @biomejs/biome in the repository rg '@biomejs/biome' -A 5Length of output: 24
Script:
#!/bin/bash # Description: Search for the configuration of the Biome pre-commit hook in the .pre-commit-config.yaml file. # Find all occurrences of Biome in the .pre-commit-config.yaml file rg 'Biome' .pre-commit-config.yaml -A 5Length of output: 39
Script:
#!/bin/bash # Description: Search for the configuration of pre-commit hooks in the .pre-commit-config.yaml file. # Find all occurrences of pre-commit hooks in the .pre-commit-config.yaml file rg 'hooks' .pre-commit-config.yaml -A 10Length of output: 2347
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 3318 3318
=========================================
Hits 3318 3318 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
New Features
Improvements