WIP use default values to set actors of tickets #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR reveals an issue in GLPI : inconsistency between default values of a ticket and showForm() |
btry
force-pushed
the
feature/629_normalize
branch
from
c49c5ff to
764c3bc
Compare
btry
force-pushed
the
feature/629_normalize
branch
3 times, most recently
from
8cb0e90 to
1c28734
Compare
btry
commented
Apr 4, 2018
inc/targetticket.class.php
Outdated
| @@ -1094,7 +1094,7 @@ public function save(PluginFormcreatorForm_Answer $formanswer) { | |||
| unset($predefined_fields['_groups_id_requester']); | |||
| } | |||
| if (isset($predefined_fields['_groups_id_observer'])) { | |||
| $this->addGroupActor('assigned', $predefined_fields['_groups_id_observer']); | |||
| $this->addGroupActor('observer', $predefined_fields['_groups_id_observer']); | |||
There was a problem hiding this comment.
copy paste problem => put the observer groups in assigned groups
btry
force-pushed
the
feature/629_normalize
branch
2 times, most recently
from
3d3fbf7 to
5a5a46e
Compare
This was referenced Apr 12, 2018
This fix solves issues with Behaiours plugin < 2.0.2 and creates tickets like GLPI does internally fix pluginsGLPI#629
btry
force-pushed
the
feature/629_normalize
branch
from
5a5a46e to
55a2299
Compare
Signed-off-by: btry <tbugier@teclib.com>
btry
force-pushed
the
feature/629_normalize
branch
from
55a2299 to
f87d54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix solves issues with Behaiours plugin < 2.0.2 and creates tickets like GLPI does internally
fix #629