Google provider: use groups.list with userKey param for group check #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
bitly_pull_500
branch
from
1bb033f to
4175d2a
Compare
instead of group members.list should support nested groups, and is shorter/simpler code too
ploxiln
force-pushed
the
bitly_pull_500
branch
from
4175d2a to
f6a736e
Compare
ploxiln
pushed a commit
that referenced
this pull request
Mar 14, 2019
more efficient, works with nested groups (it was thought that #6 added support for nested groups but it didn't)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of group members.list
should support nested groups, and is shorter/simpler code too
rebase of bitly#500
(also bitly#505 is very similar)