Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve userInGroup to make it more efficient and able to search across nested groups #28

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

sneko
Copy link

@sneko sneko commented Mar 14, 2019

I hope it will help others :)

@sneko
Copy link
Author

sneko commented Mar 14, 2019

Here an old related issue: bitly#358

@eskilandreen @snomann @framillien maybe you're still interested in :)

@ploxiln
Copy link
Owner

ploxiln commented Mar 14, 2019

Very nice!
I'm going to squash-n-merge in order to tweak the commit title and message, I hope that's fine with you.

@sneko
Copy link
Author

sneko commented Mar 14, 2019

Sure go ahead! :)

@ploxiln ploxiln merged commit 94965a2 into ploxiln:master Mar 14, 2019
@sneko
Copy link
Author

sneko commented Mar 28, 2019

@ploxiln just to follow up:

There is an issue with members that are outside the group domain (means a bug with @gmail.com in a @domain.com group).

I just discovered that. That's something on Google side but I can't figure out if this is the wanted behavior... It seems so strange.

For now they didn't answer to the issue someone has posted: https://issuetracker.google.com/issues/109861216

I will keep you updated. If they don't fix the bug I think we have to forget about using subgroups and get back to the old loops over group members 😢

EDIT: a possible way with the old way before this PR would be to set to true the "includeDerivedMembership" (https://developers.google.com/admin-sdk/directory/v1/reference/members/list). But I guess the pagination limit would be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants