This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Perform recursive lookups for group members that are themselves groups #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Google groups it is possible to make groups members of other groups. If A is a member of group G and group G is a member of group H, then A should also be considered a member of group H. This change will add append any groups found when listing group members to the array of groups to iterate through, so that eventually all top-level and nested groups will be used to check membership for the user. It is not clear whether cyclic group membership is permitted by Google but it is being checked for just in case.
|
Why is this not merged? |
|
Hello, looking around for groups handling, I found this MR also reworking this part: #500 Looks like this may fix this problem, with simplified code: groups are filtered by user email, server side (scheduled for 2.3). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Google groups it is possible to make groups members of other groups. If A is
a member of group G and group G is a member of group H, then A should also be
considered a member of group H.
This change will append any groups found when listing group members to the
array of groups to iterate through, so that eventually all top-level and nested
groups will be used to check membership for the user. It is not clear whether
cyclic group membership is permitted by Google but it is being checked for just
in case.