Create pull_request_template.md #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 add PR template
add post-merge and ci jobs check
.github/pull_request_template.md
Outdated
| - [ ] I have broken down my PR scope into the following TODO tasks | ||
| - [ ] task 1 | ||
| - [ ] task 2 | ||
| - [ ] I have passed with at least one python version with `circleci local execute` |
There was a problem hiding this comment.
- I have run the tests locally and they passed. (here's how to use
circleci local executelink???) - I have added tests for any new features or bugs I fixed
🐛 fix the contributing path
alexcjohnson
approved these changes
May 16, 2019
There was a problem hiding this comment.
@byronz I added one more checkbox to ask people to add tests (not just run the existing tests) - I'm happy with it, if you like my addition then 💃
Thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 add PR template