Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono Repo #709

Merged
merged 845 commits into from
May 22, 2019
Merged

Mono Repo #709

merged 845 commits into from
May 22, 2019

Conversation

byronz
Copy link
Contributor

@byronz byronz commented May 8, 2019 •
edited
Loading

testing

  • restructure unit test
  • resturcture integration test
  • optimize the ci config
  • linting and correcting the errors

packaging

  • adapt the build and release workflow with dev branch and new mono repo
  • add bundle assets only in master branch, dev branch should get ignored

general repo TODOs

chriddyp and others added 30 commits April 8, 2019 12:47
@chriddyp
✈️ forgot to export
ac5a2c7
@chriddyp
🍔 sloppy copy pasting
c16795e
@chriddyp
🙈
648c4b7
@chriddyp
📝 CHANGELOG
91eaf6d
@chriddyp
📖 CLIENTSIDE_ERROR constant
f79c5c7
@chriddyp
🔩 if ({}) is true
b468032
@chriddyp
🕐 treat promises like the other functions - don't break the app
b51b4fe
@chriddyp
🙈 another typo
0eddd0f
@chriddyp
🔢 no longer use ramda namespace in test
f5d3290
@chriddyp
🙉 i make this typo so frequently
d729307
@chriddyp
🔪 unify the test methods
ed4f527 
closer to the one in dash, but there are a few extra features in here:
- works with inputs (`el.text` for an input is `’’`, you have to check
`get_attribute(‘value’)`
- prints out some nicer assertion strings
@chriddyp
📝 reformat clientside tests to use existing functions
32fa44b
@chriddyp
🌹 i will never get prettier right on the first try
3eee7f4
@chriddyp
🚿 eslint
178e57f
@chriddyp
🔪 remove sample examples
5ab32c8
@chriddyp
⚡ rm unncessary comment
8aa36a9
@chriddyp
📦 new build
86dccc3
@chriddyp
📦 new build
bebfccb
@chriddyp
⚡ simpler API check as according to 7281b7d
fc49968
@chriddyp
🔒 clientside on master now
7588142
@Marc-Andre-Rivet
Upgrade to React 16 (#145)
f7810e5
remove react-16 branch shim after master merge
1ee3dce
🔀 merge back to dev-tools
1671ce8
🔀 merge back to dev-tools
cc02aab
✏️ remove redundant import
6d744ba
📦 bundles
81d39ef
💄 prettier
96391ed
🔀 merge with latest master
8ab9ac2
📦 bundles
cee4825
💄 prettier
b54c1be
@alexcjohnson alexcjohnson mentioned this pull request May 21, 2019
Closed
@byronz byronz changed the title WIP test dev branch Mono Repo May 21, 2019
alexcjohnson
alexcjohnson approved these changes May 21, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heroic. 💃 💃 💃

I see you have a couple of remaining checkboxes re: packaging/bundling - these can wait for another PR, once the tests pass, let's get this in and start using it!

@byronz byronz merged commit 7fd8787 into dev May 22, 2019
@byronz byronz deleted the monorepo branch May 23, 2019 05:03
@alexcjohnson alexcjohnson mentioned this pull request May 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@byronz @alexcjohnson @chriddyp @Marc-Andre-Rivet @nicolaskruchten