Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain #1576

Merged
merged 12 commits into from
May 6, 2021
Merged

Update toolchain #1576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
895a278
update toolchain
Mar 25, 2021
4e66254
bump CI images / py37 -> py39
Mar 25, 2021
e52b2ac
change all python 3.7 refs to 3.9
Mar 25, 2021
bb734e2
relative path
Mar 25, 2021
a7c3b7c
add back py37 temporarily for a snapshots check
Mar 25, 2021
be40da1
only snapshot py37
Mar 25, 2021
453d2c2
remove py37 ci runs
Mar 25, 2021
a0f87f7
port unit tests from jest to karma
Mar 26, 2021
4b76880
NodePolyfillPlugin
Mar 26, 2021
d4c8871
differentiate build and test config
Mar 27, 2021
e9323b3
Merge branch 'dev' into update-toolchain-20210322
Marc-Andre-Rivet May 3, 2021
961e5f9
Standardize and share Dash linting rules (#1578)
Marc-Andre-Rivet May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ jobs:

artifacts:
docker:
- image: circleci/python:3.7.9-stretch-node-browsers
- image: circleci/python:3.9.2-buster-node-browsers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to py39 and latest py36 image

auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
environment:
PYVERSION: python37
PYVERSION: python39
steps:
- checkout
- run: echo $PYVERSION > ver.txt
Expand All @@ -30,16 +30,16 @@ jobs:
path: ~/dash/packages
destination: /tmp/packages

lint-unit-37: &lint-unit
lint-unit-39: &lint-unit
working_directory: ~/dash
docker:
- image: circleci/python:3.7.9-stretch-node-browsers
- image: circleci/python:3.9.2-buster-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
environment:
PYLINTRC: .pylintrc37
PYVERSION: python37
PYLINTRC: .pylintrc39
PYVERSION: python39

steps:
- checkout
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
lint-unit-36:
<<: *lint-unit
docker:
- image: circleci/python:3.6.12-stretch-node-browsers
- image: circleci/python:3.6.13-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -92,15 +92,15 @@ jobs:
PYLINTRC: .pylintrc
PYVERSION: python27

build-core-37: &build-core
build-core-39: &build-core
working_directory: ~/dash
docker:
- image: circleci/python:3.7.9-stretch-node-browsers
- image: circleci/python:3.9.2-buster-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
environment:
PYVERSION: python37
PYVERSION: python39
steps:
- checkout
- run: echo $PYVERSION > ver.txt
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
build-core-36:
<<: *build-core
docker:
- image: circleci/python:3.6.12-stretch-node-browsers
- image: circleci/python:3.6.13-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -150,15 +150,15 @@ jobs:
environment:
PYVERSION: python27

build-misc-37: &build-misc
build-misc-39: &build-misc
working_directory: ~/dash
docker:
- image: circleci/python:3.7.9-stretch-node-browsers
- image: circleci/python:3.9.2-buster-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
environment:
PYVERSION: python37
PYVERSION: python39

steps:
- checkout
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:
build-misc-36:
<<: *build-misc
docker:
- image: circleci/python:3.6.12-stretch-node-browsers
- image: circleci/python:3.6.13-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -209,13 +209,13 @@ jobs:
environment:
PYVERSION: python27

build-windows-37:
build-windows-39:
working_directory: ~/dash
executor:
name: win/default
shell: bash.exe
environment:
PYVERSION: python37
PYVERSION: python39
steps:
- checkout
- run: echo $PYVERSION > ver.txt
Expand All @@ -236,7 +236,7 @@ jobs:
password: $DASH_PAT_DOCKERHUB
environment:
PERCY_PARALLEL_TOTAL: -1
PYVERSION: python37
PYVERSION: python39
_R_CHECK_FORCE_SUGGESTS_: FALSE

steps:
Expand Down Expand Up @@ -336,17 +336,17 @@ jobs:
when: on_fail


test-37: &test
test-39: &test
working_directory: ~/dash
docker:
- image: circleci/python:3.7.9-stretch-node-browsers
- image: circleci/python:3.9.2-buster-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
environment:
PERCY_PARALLEL_TOTAL: -1
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: True
PYVERSION: python37
PYVERSION: python39
parallelism: 3
steps:
- checkout
Expand Down Expand Up @@ -384,7 +384,7 @@ jobs:
test-36:
<<: *test
docker:
- image: circleci/python:3.6.12-stretch-node-browsers
- image: circleci/python:3.6.13-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -405,21 +405,21 @@ jobs:

workflows:
version: 2
python3.7:
python3.9:
jobs:
- lint-unit-37
- build-core-37
- build-windows-37
- build-misc-37
- lint-unit-39
- build-core-39
- build-windows-39
- build-misc-39
- build-dashr
- test-37:
- test-39:
requires:
- build-core-37
- build-misc-37
- build-core-39
- build-misc-39
- percy-finalize:
requires:
- build-dashr
- test-37
- test-39
- artifacts:
requires:
- percy-finalize
Expand Down
0 .pylintrc37 → .pylintrc39
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions @plotly/eslint-config-dash/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.tgz
3 changes: 3 additions & 0 deletions @plotly/eslint-config-dash/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# @plotly/eslint-config-dash

Shareable linting configurations for Dash projects.
26 changes: 26 additions & 0 deletions @plotly/eslint-config-dash/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
module.exports = {
extends: [
'eslint:recommended',
'prettier'
],
plugins: [
'react',
'import'
],
env: {
browser: true
},
parser: 'babel-eslint',
parserOptions: {
sourceType: 'module',
},
rules: {
'arrow-parens': [2, 'as-needed'],
'comma-dangle': [2, 'never'],
'no-unused-expressions': 2,
'no-unused-vars': 2,
'prefer-arrow-callback': 2,
'quote-props': [2, 'as-needed'],
'quotes': [2, 'single', { 'avoidEscape': true }]
}
};
Loading