Update toolchain #1576
Update toolchain #1576
Conversation
| @@ -13,12 +13,12 @@ jobs: | |||
|
|
|||
| artifacts: | |||
| docker: | |||
| - image: circleci/python:3.7.9-stretch-node-browsers | |||
| - image: circleci/python:3.9.2-buster-node-browsers | |||
There was a problem hiding this comment.
Updating to py39 and latest py36 image
dash-renderer/.eslintrc.json
Outdated
| ] | ||
| }, | ||
| "parser": "babel-eslint", | ||
| "extends": [ |
There was a problem hiding this comment.
- update eslint
- port deprecated tslint to eslint plugin
- drop redundant explict react linting configuration
| @@ -7,12 +7,4 @@ module.exports = { | |||
| plugins: [ | |||
| '@babel/plugin-proposal-class-properties', | |||
| ], | |||
| env: { | |||
There was a problem hiding this comment.
Needed by Jest but irrelevant with Karma/Mocha
|
|
||
| const WAIT = 1000; | ||
| const WAIT = 500; |
There was a problem hiding this comment.
Mocha times out by default after 2000ms. Shorten the wait to prevent failure.
| }); | ||
|
|
||
| await new Promise(r => setTimeout(r, WAIT)); | ||
| expect(done).toEqual(true); | ||
| expect(done).to.equal(true); |
There was a problem hiding this comment.
Slight syntax differences with toEqual and toBe being replaced by to.equal and to.deep.equal depending on the situation
| @@ -20,6 +20,7 @@ | |||
| "traceResolution": false | |||
| }, | |||
| "include": [ | |||
| "src/*" | |||
| "src/**/*", | |||
| "tests/**/*" | |||
There was a problem hiding this comment.
Also lint tests
| ...defaults | ||
| }; | ||
|
|
||
| module.exports = options => [ |
There was a problem hiding this comment.
Small change here allowing further customization of the Webpack configuration for (a) the build, (b) testing
| ]; | ||
| }; | ||
| module.exports = config({ | ||
| target: ['web', 'es5'] |
There was a problem hiding this comment.
New to Webpack 5, by default webpack's injected code is not ES5
| } | ||
|
|
||
| return mutateCallbacks(s, a); |
There was a problem hiding this comment.
Funny that these new rules prohibit if(...) {return a} else { return b} but not the same with else if 🤷
|
Updated checks, removing |
Fixes partially plotly/dash-core#203
py37 Percy run with all the changes, prior to bumping to py39: https://percy.io/plotly/dash/builds/9542243/unchanged/538975044?browser=firefox&viewLayout=side-by-side&viewMode=new&width=1280
py37build checks in GH