Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon.ico request now causes an Exception #189

Closed
ned2 opened this issue Jan 5, 2018 · 1 comment
Closed

favicon.ico request now causes an Exception #189

ned2 opened this issue Jan 5, 2018 · 1 comment

Comments

@ned2
Copy link
Contributor

ned2 commented Jan 5, 2018

It looks like this commit #181 and specifically this line which removed *args and **kwargs from Dash's index function signature is now causing an exception on the initial page load of an app due to the /facivon.ico request being handled by the index method, thereby getting a path=favicon.ico parameter.

As mentioned in #152 this is caused by Dash serving the index route as a catchall for otherwise unmatched routes.

Traceback (most recent call last):
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1998, in __call__
    return self.wsgi_app(environ, start_response)
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1986, in wsgi_app
    response = self.handle_exception(e)
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1540, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1983, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1615, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1613, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/nejl/.pyenv/versions/3.6.1/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1599, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
TypeError: index() got an unexpected keyword argument 'path'

@chriddyp
Copy link
Member

chriddyp commented Jan 5, 2018

ah, right, of course. yeah, let's add that back

@chriddyp chriddyp added the bug label Jan 5, 2018
chriddyp added a commit that referenced this issue Jan 5, 2018
sbvhev added a commit to sbvhev/dash that referenced this issue Mar 12, 2018
denis554 added a commit to denis554/dash that referenced this issue Apr 9, 2019
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this issue May 28, 2021
…ted-git-info-2.8.9

Bump hosted-git-info from 2.7.1 to 2.8.9
HammadTheOne pushed a commit that referenced this issue Jul 23, 2021
…t-info-2.8.9

Bump hosted-git-info from 2.7.1 to 2.8.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants